[platform/cel]: Add Celestica Silverstone device to 201811 branch #5424

mudsut4ke · 2020-09-22T07:12:54Z

- What I did

Add Silverstone platform and device

- How I did it

Add platform driver
Add 32x400G device configuration
Add 128x100G device configuration for Silverstone platform
Add reboot cause API to sonic_platform

- How to verify it

…sonic-net#3107) * sonic-device-data: update SAI config checker for Broadcom TD3 and TH3 The following properties have been approved by the Broadcom chip arch team: l3_alpm_ipv6_128b_bkt_rsvd ifp_inports_support_enable pll_bypass dpr_clock_frequency device_clock_frequency port_flex_enable mmu_port_num_mc_queue serdes_core_rx_polarity_flip_physical{<PORT>} serdes_core_tx_polarity_flip_physical{<PORT>} Signed-off-by: Dante (Kuo-Jung) Su <dante.su@broadcom.com> Change-Id: I1c6239cddfb0582a9298e671d792a32f79e4f006

lgtm-com · 2020-09-22T07:24:59Z

This pull request introduces 1 alert when merging f017c78 into 7e6fa15 - view on LGTM.com

new alerts:

1 for Unused import

…-net#3591) * [platform/broadcom] Celeatica Silverstone add IPMI platform sensor read. * [platform_sensors] Silverstone update temperature sensor description

lgtm-com · 2020-09-22T07:45:53Z

This pull request introduces 1 alert when merging 5dcdaa2 into 7e6fa15 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2020-10-01T07:07:14Z

This pull request introduces 7 alerts when merging 7faf801 into 4c80d99 - view on LGTM.com

new alerts:

6 for Except block handles 'BaseException'
1 for Unused import

zhenggen-xu · 2020-10-19T05:40:46Z

device/celestica/x86_64-cel_silverstone-r0/Silverstone-128x100/port_config.ini

@@ -0,0 +1,129 @@
+# name          lanes       alias           index       speed
+Ethernet0       33,34       QSFP1/1         1           100000
+Ethernet1       35,36       QSFP1/2         1           100000


This should be Ethernet2 instead of Ethernet1. We should reserve one interface per lane.

I agree with you, I will update it.

updated in 2d79cb5

zhenggen-xu · 2020-10-19T05:41:29Z

device/celestica/x86_64-cel_silverstone-r0/Silverstone/port_config.ini

@@ -0,0 +1,33 @@
+# name          lanes                                    alias         index    speed
+Ethernet0       33,34,35,36,37,38,39,40                  QSFPDD1       1        400000
+Ethernet4       41,42,43,44,45,46,47,48                  QSFPDD2       2        400000


This should be Ethernet8 instead of Ethernet4. We should reserve one interface per lane.

I agree with you, I will update it.

updated in 2d79cb5

zhenggen-xu · 2020-10-19T05:43:03Z

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc

@@ -0,0 +1,9 @@
+#The Port LED of Silverstone SONIC can't work well, after the issue is fixed by SAI, The led will start. 
+#led auto on; led start
+rcload /usr/share/sonic/hwsku/pre-emphasis_PAM4_optics.soc


this should be separate out from led process. Please add this into start.sh, following how it does for led.

Do you mean this start.sh , is that right ?
https://github.com/Azure/sonic-buildimage/blob/201811/platform/broadcom/docker-syncd-brcm/start.sh

Added in 6ac2ff7
Please review it

it should be removed from here.

removed in a01897c

zhenggen-xu · 2020-10-19T05:45:58Z

platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-silverstone.install

+silverstone/scripts/platform_sensors.py usr/local/bin
+silverstone/cfg/silverstone-modules.conf etc/modules-load.d
+silverstone/systemd/platform-modules-silverstone.service lib/systemd/system
+silverstone/modules/sonic_platform-1.0-py2-none-any.whl usr/share/sonic/device/x86_64-cel_silverstone-r0


why this is required?

to support reboot cause service
https://github.com/Azure/sonic-buildimage/blob/201811/files/image_config/process-reboot-cause/process-reboot-cause

ref : #3198

zhenggen-xu · 2020-10-19T05:54:55Z

src/sonic-device-data/tests/permitted_list

@@ -24,6 +25,7 @@ ext_tcam_freq
 force_core_pll
 fpem_mem_entries
 higig2_hdr_mode
+ifp_inports_support_enable


Why this change is needed? Same thing for below checks.

I will remove it

updated in 2d79cb5

[device/celestica]: update silverstone device config

[syncd-brcm]: add pre-emphasis load to start.sh

zhenggen-xu · 2020-10-21T04:38:01Z

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc

@@ -0,0 +1,9 @@
+#The Port LED of Silverstone SONIC can't work well, after the issue is fixed by SAI, The led will start. 
+#led auto on; led start
+rcload /usr/share/sonic/hwsku/pre-emphasis_PAM4_optics.soc


it should be removed from here.

zhenggen-xu · 2020-10-21T04:39:50Z

platform/broadcom/docker-syncd-brcm/start.sh

@@ -38,6 +38,12 @@ fi

 supervisorctl start syncd

+# If this platform has a pre_emphasis setting file, load it
+if [[ -r $HWSKU_DIR/pre-emphasis_PAM4_optics.soc ]]; then


If this was warm-rebooted, should we skip this one? does it impact traffic by loading this file?

updated in befd2ca

zhenggen-xu · 2020-10-21T04:56:26Z

platform/broadcom/docker-syncd-brcm/start.sh

@@ -38,6 +38,12 @@ fi

 supervisorctl start syncd

+# If this platform has a pre_emphasis setting file, load it
+if [[ -r $HWSKU_DIR/pre-emphasis_PAM4_optics.soc ]]; then
+    wait_syncd


wait_syncd should be done ONLY once at maximun.

updated in befd2ca

zhenggen-xu · 2020-10-21T05:37:58Z

Please add the test log with the image build from 201811 and this PR (Not images with other changes).
The test log should include:
"show interface status", "show environment" , "show interfaces transceiver eeprom/lpmode/presence", "show platform syseeprom/psustatus".

mudsut4ke · 2020-10-21T09:15:22Z

Please add the test log with the image build from 201811 and this PR (Not images with other changes).
The test log should include:
"show interface status", "show environment" , "show interfaces transceiver eeprom/lpmode/presence", "show platform syseeprom/psustatus".

@zhenggen-xu , The test log uploaded at https://github.com/Azure/sonic-buildimage/files/5414680/sonic-broadcom-201811_silverstone.log
Note. An error on show interfaces transceiver eeprom will resolved in a new PR that will add QSFP DD eeprom support

zhenggen-xu · 2020-10-22T05:01:46Z

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc

@@ -0,0 +1,8 @@
+#The Port LED of Silverstone SONIC can't work well, after the issue is fixed by SAI, The led will start. 
+#led auto on; led start
+sleep 10


this sleep is not needed.

removed in d6b6a8d

mudsut4ke · 2020-10-26T02:39:21Z

retest broadcom please

mudsut4ke · 2020-10-26T02:39:38Z

retest vsimage please

mudsut4ke · 2020-10-26T02:43:06Z

@yxieca , Please review and merge this PR

tiantianlv and others added 4 commits October 29, 2019 15:31

cherry pick from 368c4fa

fa6fd81

[device/celestica]: Add more permitted config for Silverstone bcm config

12de4b8

[platform/cel]: update linux image version

f017c78

pphuchar and others added 2 commits September 22, 2020 14:29

[devices] Celeatica Silverstone add IPMI platform sensor read. (sonic…

e43b107

…-net#3591) * [platform/broadcom] Celeatica Silverstone add IPMI platform sensor read. * [platform_sensors] Silverstone update temperature sensor description

Load port led FW for Silverstone! (sonic-net#4313)

5dcdaa2

Wirut Getbamrung added 2 commits October 1, 2020 13:52

[device/celestica]: add reboot cause api to silverstone

1d888f2

Merge branch '201811' into 201811-add-silverstone

7faf801

Wirut Getbamrung added 4 commits October 1, 2020 14:49

[device/celestica]: fix lgtm error

8430a18

[device/celestica]: update reboot cause api to silverstone

ada5493

[device/celestica]: add pre-emphasis_PAM4_optics config to silverstone

ac8c418

[sonic-device-data/test]: allow port_fec in permitted_list

6f4bbb4

mudsut4ke marked this pull request as ready for review October 15, 2020 03:50

zhenggen-xu reviewed Oct 19, 2020

View reviewed changes

Wirut Getbamrung added 6 commits October 19, 2020 17:05

[sonic-device-data]: remove unuse command from permitted_list

be2987d

[device/celestica]: fix sfp port name on silverstone device

6c0b9ad

Merge pull request #1075 from mudsut4ke/201811-add-silverstone-update-1

2d79cb5

[device/celestica]: update silverstone device config

[syncd-brcm]: add pre-emphasis load to start.sh

6ac2ff7

Merge pull request #1076 from mudsut4ke/201811-add-silverstone-update-1

c757bc1

[syncd-brcm]: add pre-emphasis load to start.sh

[device/celestica]: rm rcload cmd on led_proc_init of silverstone

a01897c

zhenggen-xu reviewed Oct 21, 2020

View reviewed changes

[syncd-brcm]: update pre-emphasis load in start.sh

befd2ca

zhenggen-xu reviewed Oct 22, 2020

View reviewed changes

[device/celestica]: remove unuse sleep time in led_proc_init

d6b6a8d

zhenggen-xu approved these changes Oct 22, 2020

View reviewed changes

zhenggen-xu requested a review from yxieca October 22, 2020 05:31

yxieca force-pushed the 201811 branch from 0a0bd31 to fa609b8 Compare October 26, 2022 03:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[platform/cel]: Add Celestica Silverstone device to 201811 branch #5424

[platform/cel]: Add Celestica Silverstone device to 201811 branch #5424

mudsut4ke commented Sep 22, 2020 •

edited

Loading

lgtm-com bot commented Sep 22, 2020

lgtm-com bot commented Sep 22, 2020

lgtm-com bot commented Oct 1, 2020

zhenggen-xu Oct 19, 2020

mudsut4ke Oct 19, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu Oct 19, 2020

mudsut4ke Oct 19, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu Oct 19, 2020

mudsut4ke Oct 20, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu Oct 21, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu Oct 19, 2020

mudsut4ke Oct 19, 2020

zhenggen-xu Oct 19, 2020

mudsut4ke Oct 19, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu Oct 21, 2020

zhenggen-xu Oct 21, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu Oct 21, 2020

mudsut4ke Oct 21, 2020

zhenggen-xu commented Oct 21, 2020

mudsut4ke commented Oct 21, 2020 •

edited

Loading

zhenggen-xu Oct 22, 2020

mudsut4ke Oct 22, 2020

mudsut4ke commented Oct 26, 2020

mudsut4ke commented Oct 26, 2020

mudsut4ke commented Oct 26, 2020

[platform/cel]: Add Celestica Silverstone device to 201811 branch #5424

Are you sure you want to change the base?

[platform/cel]: Add Celestica Silverstone device to 201811 branch #5424

Conversation

mudsut4ke commented Sep 22, 2020 • edited Loading

lgtm-com bot commented Sep 22, 2020

lgtm-com bot commented Sep 22, 2020

lgtm-com bot commented Oct 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhenggen-xu commented Oct 21, 2020

mudsut4ke commented Oct 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mudsut4ke commented Oct 26, 2020

mudsut4ke commented Oct 26, 2020

mudsut4ke commented Oct 26, 2020

mudsut4ke commented Sep 22, 2020 •

edited

Loading

mudsut4ke commented Oct 21, 2020 •

edited

Loading